Distinguish between glTF Validator and Language Server errors. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #68. |
|
/cc @lexaknyazev |
|
Fixes #69. I think this is ready to go. Will do a bit more testing, anyone is welcome to help me test 😄 |
|
This is merged to master now. May wait 1 more day yet to publish it, to be able to take tomorrow's Cesium release, which contains a file schema fix of mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to pull in a Validator update here too, including a slight change to
server.tsonce KhronosGroup/glTF-Validator#55 is published, which should be real soon.