Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to webview for previewing glTF files #123

Merged
merged 5 commits into from
Nov 8, 2018
Merged

Switch to webview for previewing glTF files #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0fc9cd
Clean up code
bghgary Nov 4, 2018
e9ddd03
Switch to webview for gltf preview
bghgary Nov 5, 2018
f234d64
Upgrade gltf-import-export module
bghgary Nov 5, 2018
9b264b4
Fix a couple of issues
bghgary Nov 6, 2018
31293cf
Fix environment configuration setting
bghgary Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"icon": "images/gltf.png",
"engines": {
"vscode": "^1.17.0"
"vscode": "^1.23.0"
},
"categories": [
"Formatters",
Expand Down Expand Up @@ -54,12 +54,12 @@
},
"glTF.Babylon.environment": {
"type": "string",
"default": "{extensionRootPath}/environments/babylon/countrySpecularHDR.dds",
"default": "{extensionRootPath}environments/babylon/countrySpecularHDR.dds",
"description": "The path to a BabylonJS-ready DDS environment file. See: https://doc.babylonjs.com/how_to/physically_based_rendering#creating-a-dds-environment-file-from-an-hdr-image"
},
"glTF.Three.environment": {
"type": "string",
"default": "{extensionRootPath}/environments/threejs/Park2/{face}.jpg",
"default": "{extensionRootPath}environments/threejs/Park2/{face}.jpg",
"description": "The path to a set of environment cube faces usable by ThreeJS. Use {face} for the face name, and six files must exist with the following face names: posx, negx, posy, negy, posz, and negz."
},
"glTF.showToolbar3D": {
Expand Down Expand Up @@ -296,7 +296,7 @@
"babylonjs": "^3.2.0",
"babylonjs-loaders": "^3.2.0",
"draco3dgltf": "^1.3.4",
"gltf-import-export": "^1.0.12",
"gltf-import-export": "^1.0.13",
"gltf-validator": "2.0.0-dev.2.5",
"json-source-map": "^0.4.0",
"sprintf-js": "^1.1.1",
Expand Down
2 changes: 0 additions & 2 deletions server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

import {
IPCMessageReader, IPCMessageWriter, createConnection, IConnection, TextDocuments, TextDocument,
Diagnostic, DiagnosticSeverity, InitializeResult, Position, Range, TextDocumentPositionParams, Hover, MarkedString,
Expand Down
5 changes: 3 additions & 2 deletions server/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"compilerOptions": {
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitAny": false,
"noImplicitReturns": true,
"target": "es6",
"target": "es2017",
"module": "commonjs",
"moduleResolution": "node",
"sourceMap": true,
"lib" : [ "es2016" ],
"lib" : [ "es2017" ],
"outDir": "."
},
"exclude": [
Expand Down
Loading