Make Polyline and Path use materials #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of most invidual properties and use materials instead Add PolylineOutline and PolylineGlow materials.
PolylineMaterial.jsonschema - Materials applicable to polylines and paths. Material.jsonschema - materials applicable to everything else. This has no affect on the resulting CZML, it just makes it impossible to write out a material that is incompatible with it's intended object.
emackey
added a commit
that referenced
this pull request
Jul 11, 2014
Make Polyline and Path use materials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of most invidual properties and use materials instead
Add PolylineOutline and PolylineGlow materials.
This goes along with CesiumGS/cesium/pull/1904
One possibility is to have a PolylineMaterial.jsonschema instead of using Material.jsonschema. This will allow us to restrict the materials polylines can use down to a specific set. What do you guys think?
EDIT: I decided
PolylineMaterial.jsonschemawas a good idea so I added that (see the second commit below for details).