Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema for label backgrounds. #123

Merged
merged 12 commits into from
Dec 19, 2016
Merged

Update schema for label backgrounds. #123

merged 12 commits into from
Dec 19, 2016

Conversation

emackey
Copy link
Member

@emackey emackey commented Dec 9, 2016 •
edited
Loading

For CesiumGS/cesium#4715.

TODO

  • Regenerate code

@emackey emackey mentioned this pull request Dec 9, 2016
Merged
6 tasks
@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 15, 2016

@shunter do you want to review?

@emackey
Copy link
Member Author

emackey commented Dec 16, 2016

This is ready.

@emackey
Copy link
Member Author

emackey commented Dec 16, 2016

This is NOT ready. I'm getting

The type or namespace BackgroundPaddingCesiumWriter could not be found.

@emackey
Copy link
Member Author

emackey commented Dec 16, 2016

Fixed. This is ready again.

@shunter
Copy link
Member

shunter commented Dec 19, 2016

I used this branch to add the other CZML properties that were put into Cesium but not added to the writer. Merging.

@shunter shunter merged commit 803e604 into master Dec 19, 2016
@shunter shunter deleted the label-backgrounds branch December 19, 2016 22:17
@emackey emackey mentioned this pull request Dec 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emackey @pjcozzi @shunter