Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https instead of // everywhere by default #3650

Closed
mramato opened this issue Mar 1, 2016 · 0 comments
Closed

Use https instead of // everywhere by default #3650

mramato opened this issue Mar 1, 2016 · 0 comments
Labels
cleanup good first issue An opportunity for first time contributors

Comments

@mramato
Copy link
Contributor

mramato commented Mar 1, 2016

Traditionally, using // was standard practice because it would use the protocol of the existing page, i.e. http on http pages, https on https pages. With the pending transition to https everywhere, it makes sense for us to replace // everywhere we currently use it with https instead.

Furthermore, using // in offline apps (such as cordova or webviews) causes // to become file:// which means Cesium is broken by default in those situations. This will save developers writing those apps the initial headaches they've had in the past.

@mramato mramato added cleanup good first issue An opportunity for first time contributors labels Mar 1, 2016
This was referenced Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

1 participant