Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/design system poc #4

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Chore/design system poc #4

merged 9 commits into from
Jul 6, 2021

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Jul 3, 2021

Related Issue

Setting up a PR to demo out a few potential workflows for implementing and maintaining a design system, and the stack I would like to evaluate:

  • Lit for Web Component library
  • Storybook for developing the design system itself
  • Modern Web Test Runner tests
  • Typescript???

Home Page
Screen Shot 2021-07-03 at 5 05 59 PM

Storybook
Screen Shot 2021-07-03 at 5 03 33 PM

Open to suggestions and feedback! 👀

Summary of Changes

  1. Added Lit and created a very simple footer component
  2. Added [@web/test-runner`(https://modern-web.dev/docs/test-runner/overview/) for BDD and browser based unit testing
  3. Added Storybook scaffolding for components and design system
  4. Introduced theming through use of CSS Custom Properties (e.g. variables)

TODO

  1. Validate testing works in CI
  2. Explore Storybook for a design system / component library management
  3. Ideally would be nice to get this all using CSS Variables 🙌
  4. Explore using TypeScript? (would need a custom Greenwood plugin for this) 👀 🤞 - see migrate (back) to TypeScript #6
  5. (nice to have) Storybook + Bundless / Web Dev Server 🥺

@thescientist13 thescientist13 added help wanted Extra attention is needed chore labels Jul 3, 2021
@thescientist13 thescientist13 self-assigned this Jul 3, 2021
@netlify
Copy link

netlify bot commented Jul 3, 2021

✔️ Deploy Preview for practical-fermat-fa2c48 ready!

🔨 Explore the source changes: 4b275e6

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-fermat-fa2c48/deploys/60e0d52f4f1a5f000796749e

😎 Browse the preview: https://deploy-preview-4--practical-fermat-fa2c48.netlify.app/

@thescientist13 thescientist13 removed the help wanted Extra attention is needed label Jul 3, 2021
@thescientist13 thescientist13 marked this pull request as ready for review July 3, 2021 21:26
@thescientist13 thescientist13 merged commit 7d016ed into main Jul 6, 2021
@thescientist13 thescientist13 deleted the chore/design-system-poc branch July 6, 2021 13:29
@thescientist13 thescientist13 linked an issue Jul 30, 2021 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jamstack Discovery and Planning
1 participant