Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Scrutiny should be cgroup aware #584

Open
uhthomas opened this issue Feb 26, 2024 · 0 comments · May be fixed by #585
Open

[BUG] Scrutiny should be cgroup aware #584

uhthomas opened this issue Feb 26, 2024 · 0 comments · May be fixed by #585
Labels
bug Something isn't working

Comments

@uhthomas
Copy link
Contributor

uhthomas commented Feb 26, 2024 •
edited
Loading

Describe the bug

Go is not cgroup aware. This means that Scrutiny will be throttled hard in containerised environments with CPU limits.

The below screenshot shows the container with a CPU limit in Kubernetes. The first half of the time series is on a 13600k, with 20 threads. The second half is when the machine changed to use an EPYC 7763 with 128 threads.

image

Expected behavior

Scrutiny should not be CPU throttling with adequate resources, and the throttling should not scale with the number of available threads.

automaxprocs can use cgroups automatically.

Screenshots

See above.

Log Files

N/A
@uhthomas uhthomas added the bug Something isn't working label Feb 26, 2024
uhthomas added a commit to uhthomas/scrutiny that referenced this issue Feb 26, 2024
@uhthomas
chore: use Linux container CPU quota
a4a6a0c 
Go is not cgroup aware and by default will set GOMAXPROCS to the number
of available threads, regardless of whether it is within the allocated
quota. This behaviour causes high amount of CPU throttling and degraded
application performance.

Fixes: AnalogJ#584
@uhthomas uhthomas linked a pull request Feb 26, 2024 that will close this issue
Open
uhthomas added a commit to uhthomas/scrutiny that referenced this issue Feb 26, 2024
@uhthomas
chore: use Linux container CPU quota
cc5b414 
Go is not cgroup aware and by default will set GOMAXPROCS to the number
of available threads, regardless of whether it is within the allocated
quota. This behaviour causes high amount of CPU throttling and degraded
application performance.

Fixes: AnalogJ#584
uhthomas added a commit to uhthomas/automata that referenced this issue May 2, 2024
@uhthomas
chore(k8s/amour/scrutiny): set GOMAXPROCS
661dc25 
AnalogJ/scrutiny#584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use Linux container CPU quota uhthomas/scrutiny
1 participant
@uhthomas