Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor authentication #552

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Refactor authentication #552

merged 2 commits into from
Nov 20, 2023

Conversation

fremartini
Copy link
Member

No description provided.

@fremartini fremartini mentioned this pull request Nov 19, 2023
Closed
@fremartini fremartini enabled auto-merge (squash) November 19, 2023 14:29
@ghost
Copy link

ghost commented Nov 19, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (db0df6d) 72.85% compared to head (3edc963) 72.70%.

Files Patch % Lines
...ation/domain/usecases/save_authenticated_user.dart 0.00% 4 Missing ⚠️
...tion/domain/usecases/clear_authenticated_user.dart 0.00% 3 Missing ⚠️
...cation/domain/usecases/get_authenticated_user.dart 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   72.85%   72.70%   -0.15%     
==========================================
  Files         130      134       +4     
  Lines        1573     1601      +28     
==========================================
+ Hits         1146     1164      +18     
- Misses        427      437      +10
Flag Coverage Δ
unittests 72.70% <86.66%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fremartini fremartini requested a review from a team November 19, 2023 14:35
TTA777
TTA777 requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, but not a fan of the nullable user

lib/features/authentication/data/datasources/authentication_local_data_source.dart Outdated Show resolved Hide resolved
lib/features/authentication/data/models/authenticated_user_model.dart Show resolved Hide resolved
@fremartini fremartini requested a review from TTA777 November 20, 2023 17:30
TTA777
TTA777 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fremartini fremartini merged commit d9f1ddd into main Nov 20, 2023
9 of 10 checks passed
@fremartini fremartini deleted the frem/refactor_authentication branch November 20, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTA777 TTA777 TTA777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fremartini @TTA777