Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async-timeout to ray-core #235

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Add async-timeout to ray-core #235

merged 4 commits into from
Oct 17, 2024

Conversation

ViridianMelody
Copy link
Contributor

@ViridianMelody ViridianMelody commented Aug 8, 2024

Links

Explanation of changes:

  • Per this issue, ray depends on async-timeout, but has relied on aiohttp to provide it. Sinceaiohttp no longer requires async-timeout, it's necessary to add it to ray.
  • I've confirmed that async-timeout has been imported since at least ray 1.0, and therefore applies to all versions present on main.

@ViridianMelody ViridianMelody marked this pull request as ready for review October 17, 2024 18:13
@ViridianMelody ViridianMelody merged commit 077ed82 into master Oct 17, 2024
2 checks passed
@ViridianMelody ViridianMelody deleted the ray-async-timeout branch October 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants