-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.13.7 #3
Conversation
Linter check failed, with the following output: ERROR: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Linter check failed, with the following output: ERROR: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Can you use two license URLs? The linter crashes when you do and since it's not a hard requirement, I would skip this for now. |
Linter check failed, with the following output: ERROR: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Linter check failed, with the following output: ERROR: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Linter check failed, with the following output: ERROR: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Thank you both! I think I addressed your comments. |
Linter check failed, with the following output: ERROR: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might still want to add the license url
license_url: https://github.com/PyO3/maturin/blob/main/license-apache
license_url: https://github.com/PyO3/maturin/blob/main/license-apache
There are two licenses, so we would need two license URLs. Can you do that? The linter crashes when you do. Since it's not a hard requirement, I would skip this for now. If you think this should become hard requirement, I would appreciate input in our standards document: https://github.com/anaconda-distribution/perseverance-skills/pull/37 |
It should be ok to skip, just wanted to know if we could satisfy the linter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request looks good for the most part, we just want to make sure that the package builds for win-64
we could also use concourse to build the missing architectures.
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests. |
orjson -> maturin
Package Info
Home: https://maturin.rs/
Development: https://github.com/PyO3/maturin
Documentation: https://maturin.rs/
Change log: PyO3/maturin@v0.11.5...v0.13.3