Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.13.7 #3

Merged
merged 28 commits into from
Nov 9, 2022
Merged

Update to v0.13.7 #3

merged 28 commits into from
Nov 9, 2022

Conversation

marcoesters
Copy link

orjson -> maturin

Package Info

Home: https://maturin.rs/
Development: https://github.com/PyO3/maturin
Documentation: https://maturin.rs/
Change log: PyO3/maturin@v0.11.5...v0.13.3

@marcoesters marcoesters closed this Oct 6, 2022
@marcoesters marcoesters reopened this Oct 6, 2022
@marcoesters marcoesters changed the title Update to v0.13.6 Update to v0.13.7 Nov 1, 2022
@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:66: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:76: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_8f122poji8/clone/recipe/meta.yaml:77: missing_license_url: The recipe is missing a license_url
Errors were found

@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:66: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:76: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_4b3by_mn1e/clone/recipe/meta.yaml:77: missing_license_url: The recipe is missing a license_url
Errors were found

@marcoesters
Copy link
Author

Since pip is mentioned in the host section, we have to add pip check in the test section.

- pip # [win]

The following could be a potential doc_source_url: doc_source_url: https://github.com/PyO3/maturin/tree/main/guide/src

license_url: https://github.com/PyO3/maturin/blob/main/license-mit license_url: https://github.com/PyO3/maturin/blob/main/license-apache

description: This project is meant as a zero configuration replacement for setuptools-rust and milksnake. It supports building wheels for python 3.5+ on windows, linux, mac and freebsd, can upload them to pypi and has basic pypy support.

Can you use two license URLs? The linter crashes when you do and since it's not a hard requirement, I would skip this for now.

@marcoesters marcoesters closed this Nov 1, 2022
@marcoesters marcoesters reopened this Nov 1, 2022
@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:66: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:76: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_d7ul25qg7m/clone/recipe/meta.yaml:77: missing_license_url: The recipe is missing a license_url
Errors were found

@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:70: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:80: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_74nxs8qlc_/clone/recipe/meta.yaml:81: missing_license_url: The recipe is missing a license_url
Errors were found

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:78: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:88: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_58_uko4w5i/clone/recipe/meta.yaml:89: missing_license_url: The recipe is missing a license_url
Errors were found

@marcoesters
Copy link
Author

Thank you both! I think I addressed your comments.

@anaconda-pkg-build
Copy link

Linter check failed, with the following output:
The following problems have been found:

ERROR: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:78: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:88: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_efl04tv9ti/clone/recipe/meta.yaml:89: missing_license_url: The recipe is missing a license_url
Errors were found

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoesters
Copy link
Author

we might still want to add the license url license_url: https://github.com/PyO3/maturin/blob/main/license-apache license_url: https://github.com/PyO3/maturin/blob/main/license-apache

There are two licenses, so we would need two license URLs. Can you do that? The linter crashes when you do.

Since it's not a hard requirement, I would skip this for now. If you think this should become hard requirement, I would appreciate input in our standards document: https://github.com/anaconda-distribution/perseverance-skills/pull/37

@varlackc
Copy link

varlackc commented Nov 3, 2022

we might still want to add the license url license_url: https://github.com/PyO3/maturin/blob/main/license-apache license_url: https://github.com/PyO3/maturin/blob/main/license-apache

There are two licenses, so we would need two license URLs. Can you do that? The linter crashes when you do.

Since it's not a hard requirement, I would skip this for now. If you think this should become hard requirement, I would appreciate input in our standards document: anaconda-distribution/perseverance-skills#37

It should be ok to skip, just wanted to know if we could satisfy the linter.

@varlackc varlackc self-requested a review November 7, 2022 05:36
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request looks good for the most part, we just want to make sure that the package builds for win-64 we could also use concourse to build the missing architectures.

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:78: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:88: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_f34ufw8rut/clone/recipe/meta.yaml:89: missing_license_url: The recipe is missing a license_url
Errors were found

@marcoesters marcoesters merged commit b405e8d into master Nov 9, 2022
@marcoesters marcoesters deleted the update-13.2 branch November 9, 2022 02:18
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:0: missing_tests: The recipe is missing tests.
ERROR: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:78: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
ERROR: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:88: invalid_url: https://maturin.rs/ : URL domain redirect maturin.rs -> www.maturin.rs
WARNING: /tmp/abs_c46vgqojxl/clone/recipe/meta.yaml:89: missing_license_url: The recipe is missing a license_url
Errors were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants