Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navigation for request Body files #250

Merged
merged 4 commits into from
Jan 14, 2024

Conversation

mondhs
Copy link

@mondhs mondhs commented Dec 30, 2023

Request add navigation for request body files.

Idea is that if I have many request files it would be nice to jump over when ever I need for review or editing. It would like this:

test_httpyac-1703946442023

Currently it works with json extension files as I am using them most, but this filtering list might externalized to configuration in a future.

My code is based on https://github.com/abierbaum/vscode-file-peek

@AnWeber
Copy link
Owner

AnWeber commented Jan 4, 2024

The idea is great. I'm just wondering whether it's really necessary to parse the location links separately. I already parse the file with the httpyac lib to provide the code lens. To get the needed Positions for the CodeLens I use a HttpSymbol
. If we also specifically mark the links in these symbols (new SymbolKind.File), we could generalize the problem and thus also use the parsing for the import of Proto files, for example.

@mondhs
Copy link
Author

mondhs commented Jan 5, 2024

I refactored code to used HttpRegions and removed bunch of redundant code and overwhelming logging.

If it would be symbol such as file for requests, imports etc, it would be possible get universal solution.

@mondhs
Copy link
Author

mondhs commented Jan 14, 2024

@AnWeber Could I change my pull request to make it acceptable?

@AnWeber
Copy link
Owner

AnWeber commented Jan 14, 2024

@mondhs Hi sorry the ball is in my court. Unfortunately, I'm really out of action at the moment due to a corona illness. I'm slowly getting back. I'll take a look at it soon. Sorry for the delay.

@AnWeber AnWeber merged commit 645a324 into AnWeber:main Jan 14, 2024
2 checks passed
@AnWeber
Copy link
Owner

AnWeber commented Jan 14, 2024

thx for your contribution. I have added support for a few more file imports (gql, proto, intellij script import) and released it now. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants