Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add classname, time and file to testcases #579

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

mmadson
Copy link

@mmadson mmadson commented Nov 2, 2023

the duration calculation for testCase assertions is totally a hack. Also the filename being relative to repo root allows gitlab to link to the file in the repo directly.

@AnWeber AnWeber merged commit 889c53b into AnWeber:main Nov 2, 2023
1 of 3 checks passed
@AnWeber
Copy link
Owner

AnWeber commented Nov 2, 2023

@mmadson I will remove attr file on testcase because this is not mentioned in xsd. Or was that property intentional?

@mmadson
Copy link
Author

mmadson commented Nov 3, 2023

@mmadson I will remove attr file on testcase because this is not mentioned in xsd. Or was that property intentional?

@AnWeber it was actually intentional to add the file attr to that tag; for some reason that is where gitlab expects to find the file information. So long as the path is relative to the repo root it also creates a link directly to the file.

@AnWeber
Copy link
Owner

AnWeber commented Nov 3, 2023

Ok, I will add it. I readded file attribute to testcase. Could you please test updated junit with gitlab? You can use new Image Tag edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants