feat: Add MegaMenu component #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-486-MegaMenu
…into feature/DES-486-MegaMenu
…into feature/DES-486-MegaMenu
alimpens
reviewed
Dec 22, 2023
proprietary/tokens/src/components/amsterdam/mega-menu.tokens.json
Outdated
Show resolved
Hide resolved
…into feature/DES-486-MegaMenu
alimpens
reviewed
Jan 9, 2024
VincentSmedinga
requested changes
Jan 10, 2024
…into feature/DES-486-MegaMenu
dlnr
commented
Jan 15, 2024
There was a problem hiding this comment.
I think the general pattern is to wrap everything (PageMenu + MegaMenu) in a
nav, see also Accessible Mega Menu
As discussed we will resolve this in the header-megamenu PR.
VincentSmedinga
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial grid setup of the Mega Menu component, which will be developed further when added to header.