Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply regular font size to lists of links #875

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: Apply regular font size to lists of links #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
085b9cc
Apply regular font size to lists of links
VincentSmedinga Dec 1, 2023
0b48363
Match icon size
VincentSmedinga Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const Link = forwardRef(
className,
)}
>
{variant === 'inList' && <Icon svg={icon ?? ChevronRightIcon} size="level-7" />}
{variant === 'inList' && <Icon svg={icon ?? ChevronRightIcon} size="level-6" />}
{children}
</a>
),
Expand Down
8 changes: 4 additions & 4 deletions proprietary/tokens/src/components/amsterdam/link.tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@
"text-decoration-line": { "value": "{amsterdam.link-appearance.subtle.hover.text-decoration-line}" }
},
"spacious": {
"font-size": { "value": "{amsterdam.typography.spacious.text-level.7.font-size}" },
"line-height": { "value": "{amsterdam.typography.spacious.text-level.7.line-height}" }
"font-size": { "value": "{amsterdam.typography.spacious.text-level.6.font-size}" },
"line-height": { "value": "{amsterdam.typography.spacious.text-level.6.line-height}" }
},
"compact": {
"font-size": { "value": "{amsterdam.typography.compact.text-level.7.font-size}" },
"line-height": { "value": "{amsterdam.typography.compact.text-level.7.line-height}" }
"font-size": { "value": "{amsterdam.typography.compact.text-level.6.font-size}" },
"line-height": { "value": "{amsterdam.typography.compact.text-level.6.line-height}" }
}
},
"standalone": {
Expand Down
18 changes: 9 additions & 9 deletions storybook/storybook-docs/src/typography.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ Elk typografisch element zit op 1 zo’n niveau: titel, paragraaf, link, citaat,
Ze zijn genummerd van 0 tot en met 6 – zo komen ze voor de diverse titels mooi overeen.
Voorbeelden:

| Niveau | Componenten |
| -----: | :--------------------------------------------------- |
| 0 | Page heading |
| 1 | Heading 1 |
| 2 | Heading 2 |
| 3 | Heading 3, Blockquote |
| 4 | Heading 4, Large Paragraph |
| 5 | Paragraph, Button, Link behalve InList |
| 6 | Small Paragraph, InList Link, Form Label, Breadcrumb |
| Niveau | Componenten |
| -----: | :------------------------------------- |
| 0 | Page heading |
| 1 | Heading 1 |
| 2 | Heading 2 |
| 3 | Heading 3, Blockquote |
| 4 | Heading 4, Large Paragraph |
| 5 | Paragraph, List, Link, Button |
| 6 | Small Paragraph, Page Menu, Breadcrumb |

### Responsive

Expand Down