feat: Add common link tokens and use them in all link-like components #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
changed the title
alimpens
changed the title
…into feature/DES-424-fix-link-styling
github-actions
bot
temporarily deployed
to
demo-DES-424-fix-link-styling
proprietary/tokens/src/components/amsterdam/breadcrumb.tokens.json
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/amsterdam/page-menu.tokens.json
Outdated
Show resolved
Hide resolved
alimpens
commented
Nov 27, 2023
proprietary/tokens/src/components/amsterdam/breadcrumb.tokens.json
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/amsterdam/pagination.tokens.json
Outdated
Show resolved
Hide resolved
I think it was mostly some Aphex Twin, which I wouldn't recommend for a focus playlist 😅 |
github-actions
bot
temporarily deployed
to
demo-DES-424-fix-link-styling
…into feature/DES-424-fix-link-styling
github-actions
bot
temporarily deployed
to
demo-DES-424-fix-link-styling
…into feature/DES-424-fix-link-styling
github-actions
bot
temporarily deployed
to
demo-DES-424-fix-link-styling
VincentSmedinga
approved these changes
Nov 30, 2023
proprietary/tokens/src/components/amsterdam/pagination.tokens.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done 2 things in this PR:
src/common, and all components are moved tosrc/components. This caused a lot of changes, sorry!link-typesto our common tokens layer, which is now used in all our components that look like links. If anyone has a better name thanlink-types, let me know!