docs: Fix incorrect widths in grid documentation #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # storybook/storybook-docs/src/grid.stories.mdx
dlnr
reviewed
Nov 23, 2023
alimpens
reviewed
Nov 24, 2023
Co-authored-by: Aram <[email protected]>
This reverts commit 11dadbb.
VincentSmedinga
changed the title
dlnr
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appeared that I had made some mistakes in the tables describing the various grid widths. The first commit resolves these. This should be published soon.
The second improves the grid’s design documentation.
The third changes the unused extra wide maximum width for Screen to a ‘full width’ prop.Reverted until we’re sure we don’t need this prop.