Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logo Component #755

Merged
merged 37 commits into from
Nov 22, 2023
Merged

Add Logo Component #755

merged 37 commits into from
Nov 22, 2023

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Nov 14, 2023

No description provided.

@dlnr dlnr requested a review from VincentSmedinga November 14, 2023 13:17
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 14, 2023 13:38 Destroyed
@VincentSmedinga VincentSmedinga force-pushed the feature/DES-492-logo-component branch from 55fcdfd to f13f61b Compare November 14, 2023 19:40
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 14, 2023 19:42 Destroyed
packages/css/src/logo/logo.scss Outdated Show resolved Hide resolved
packages/css/src/logo/logo.scss Outdated Show resolved Hide resolved
packages/react/src/Logo/Logo.tsx Outdated Show resolved Hide resolved
packages/react/src/Logo/Logo.tsx Outdated Show resolved Hide resolved
packages/react/src/Logo/Logo.tsx Outdated Show resolved Hide resolved
proprietary/assets/logo/ggd-amsterdam.svg Outdated Show resolved Hide resolved
storybook/storybook-react/src/Logo/Logo.stories.tsx Outdated Show resolved Hide resolved
@VincentSmedinga
Copy link
Contributor

How could product teams not using React still get our logo svg in their application? Should that be a separate task?

@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 08:08 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 10:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 10:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 10:56 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 11:01 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 11:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 15, 2023 11:39 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 16, 2023 10:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 16, 2023 10:57 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 16, 2023 11:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 16, 2023 16:14 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 16, 2023 16:19 Destroyed
@alimpens alimpens changed the base branch from main to develop November 17, 2023 12:26
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 17, 2023 13:39 Destroyed
packages/css/src/logo/logo.scss Outdated Show resolved Hide resolved
packages/react/src/Logo/Logo.tsx Outdated Show resolved Hide resolved
packages/css/src/logo/logo.scss Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 08:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 09:11 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 09:57 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 12:05 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 12:09 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-492-logo-component November 22, 2023 14:40 Destroyed
@alimpens alimpens merged commit a71cd66 into develop Nov 22, 2023
3 checks passed
@alimpens alimpens deleted the feature/DES-492-logo-component branch November 22, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants