Set screen language to Dutch #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for more languages may follow – see https://amsterdam.nl/stijlweb/heldere-taal/engels-talen/.
dlnr
approved these changes
Nov 7, 2023
VincentSmedinga
added a commit
that referenced
this pull request
Nov 8, 2023
This reverts commit 6a111da.
alimpens
added a commit
that referenced
this pull request
Nov 9, 2023
* Revert "Set screen language to Dutch (#710)" This reverts commit 6a111da. * Update documentation on the language attribute --------- Co-authored-by: Aram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this to the
Screencomponent is appropriate as it’s the outermost component we have control over and it applies to the entire tree (“If these attributes are omitted from an element, then the language of this element is the same as the language of its parent element, if any” – Spec)Support for more languages through a prop with a number of options may follow – see https://amsterdam.nl/stijlweb/heldere-taal/engels-talen/.