Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dialog component #681

Merged
merged 34 commits into from
Nov 21, 2023
Merged

Add Dialog component #681

merged 34 commits into from
Nov 21, 2023

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 27, 2023

No description provided.

@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog October 27, 2023 19:06 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 7, 2023 09:38 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 8, 2023 09:42 Destroyed
@dlnr dlnr marked this pull request as ready for review November 8, 2023 09:45
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 8, 2023 10:20 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 8, 2023 10:22 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 8, 2023 10:24 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 9, 2023 13:17 Destroyed
@github-actions github-actions bot temporarily deployed to staging-feature-DES-253-modal-dialog November 9, 2023 13:19 Destroyed
alimpens
alimpens reviewed Nov 10, 2023
View reviewed changes
packages/css/src/dialog/README.md Outdated Show resolved Hide resolved
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
storybook/storybook-react/src/Dialog/Dialog.stories.tsx Outdated Show resolved Hide resolved
storybook/storybook-react/config/story.css Outdated Show resolved Hide resolved
storybook/storybook-react/src/Dialog/Dialog.stories.tsx Outdated Show resolved Hide resolved
storybook/storybook-react/src/Dialog/Dialog.stories.tsx Outdated Show resolved Hide resolved
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
alimpens
alimpens reviewed Nov 13, 2023
View reviewed changes
packages/css/src/dialog/dialog.scss Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 14, 2023 10:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 16, 2023 13:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 16, 2023 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 16, 2023 14:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 16, 2023 14:56 Destroyed
alimpens
alimpens reviewed Nov 16, 2023
View reviewed changes
packages/react/src/Dialog/Dialog.tsx Outdated Show resolved Hide resolved
storybook/storybook-react/config/preview.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 16, 2023 16:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 17, 2023 09:09 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 17, 2023 09:12 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 17, 2023 09:28 Destroyed
@alimpens alimpens changed the base branch from main to develop November 17, 2023 12:27
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 21, 2023 08:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 21, 2023 14:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-253-modal-dialog November 21, 2023 14:34 Destroyed
@alimpens alimpens merged commit be75d9f into develop Nov 21, 2023
3 checks passed
@alimpens alimpens deleted the feature/DES-253-modal-dialog branch November 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@VincentSmedinga VincentSmedinga Awaiting requested review from VincentSmedinga

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlnr @alimpens