-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination component #674
Add pagination component #674
Conversation
…o feature/DES-399-add-pagination-component
These should totally be links from the start. I don’t think something happening either client-side or server-side is a decisive factor to make an action count as navigating or not. If it is, would a user of a single-page app ever be navigating? An SPA is free to hijack the url and replace it with client-side routing. But they should push the url onto the navigation history to make the end result look like a navigation happened. https://twitter.com/housecor/status/1717152910713278544 We want users to be able to share the link to a specific page. |
Yes. I had to get used a bit to the idea of the component doing these calculations, but seeing it in action I think it’s the right way ahead. |
Static is fine for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice. It is a complex component! good job
…o feature/DES-399-add-pagination-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just submitted my comments – only now I notice they have been ‘pending’ for a week…
Based on ASC Pagination.
Couple of questions:
page
,pageSize
andcollectionSize
props. I can imagine some apps get this calculation already from their backend, so maybe we should make this calculation optional? Again, maybe we should wait until we have users that need this.aria-label
s and previous- and next-button text content? Or should that be configurable?