Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial git guidelines #490

Merged
merged 22 commits into from
Sep 29, 2023
Merged

Add initial git guidelines #490

merged 22 commits into from
Sep 29, 2023

Conversation

VincentSmedinga
Copy link
Contributor

No description provided.

@alimpens alimpens marked this pull request as draft September 5, 2023 12:12
@VincentSmedinga VincentSmedinga force-pushed the task/add-git-guidelines branch 2 times, most recently from 3574175 to 3b7d7c2 Compare September 26, 2023 09:43
@VincentSmedinga VincentSmedinga marked this pull request as ready for review September 26, 2023 09:45
alimpens
alimpens reviewed Sep 26, 2023
View reviewed changes
documentation/code-reviews.md Outdated Show resolved Hide resolved
documentation/code-reviews.md Outdated Show resolved Hide resolved
documentation/code-reviews.md Outdated Show resolved Hide resolved
documentation/code-reviews.md Outdated Show resolved Hide resolved
documentation/code-reviews.md Show resolved Hide resolved
documentation/git.md Outdated Show resolved Hide resolved
documentation/git.md Outdated Show resolved Hide resolved
documentation/git.md Outdated Show resolved Hide resolved
documentation/git.md Outdated Show resolved Hide resolved
documentation/git.md Outdated Show resolved Hide resolved
dlnr
dlnr previously approved these changes Sep 29, 2023
View reviewed changes
documentation/git.md Outdated Show resolved Hide resolved
documentation/git.md Show resolved Hide resolved
VincentSmedinga and others added 17 commits September 29, 2023 11:44
@VincentSmedinga
Add initial git guidelines
3f82966
@VincentSmedinga @dlnr
Improve command to prune branches
1bb96d8 
Co-authored-by: Niels Roozemond <[email protected]>
@VincentSmedinga
Extract code review guidelines
36c261e
@VincentSmedinga
Simplify other documentation file names
a97925d
@VincentSmedinga
Translate with Google
9be9fd4
@VincentSmedinga
Rewrite Git guidelines
f24b1e0
@VincentSmedinga
Rewrite code reviewing guidelines
8116aa0
@VincentSmedinga @alimpens
Improve documentation
72e1bee 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga @alimpens
Improve documentation
6572476 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga @alimpens
Improve documentation
0d96ea8 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga @alimpens
Improve documentation
4dc86a0 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga @alimpens
Improve documentation
bb74506 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga @alimpens
Improve documentation
170cafb 
Co-authored-by: Aram <[email protected]>
@VincentSmedinga
Improve the command to update the main branch without switching
db0255b 
Source: https://stackoverflow.com/a/17722977/2169092
@VincentSmedinga
Correct that force-with-lease doesn’t make you lose worl
22b0b46
@VincentSmedinga
Improve the command to update the local main branch before merging it
2399857
@VincentSmedinga
Express that the author of a comment, not of the PR, resolves it
530cee5
@alimpens alimpens merged commit 0ffabba into main Sep 29, 2023
3 checks passed
@alimpens alimpens deleted the task/add-git-guidelines branch September 29, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@dlnr dlnr dlnr left review comments

@hcvdhaar hcvdhaar Awaiting requested review from hcvdhaar

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentSmedinga @dlnr @alimpens