Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace deprecated import statements in Sass with new API #1777

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Dec 9, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Applied the SASS recommended migrator to fix the @import deprecation.

Why

Warnings in build output.

How

npm install -g sass-migrator
sass-migrator module --migrate-deps index.scss

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 9, 2024 14:50 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring. I didn’t anticipate the namespace it would add; let’s decide on a good approach to keep the mixin names user-friendly.

packages/css/src/components/blockquote/blockquote.scss Outdated Show resolved Hide resolved
packages/css/src/components/breakout/breakout.scss Outdated Show resolved Hide resolved
@VincentSmedinga VincentSmedinga changed the title feat: Replace SASS imports feat: Replace deprecated import statements in Sass with new API Dec 10, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 10, 2024 14:59 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 13, 2024 10:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 13, 2024 10:31 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 13, 2024 10:33 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1001-replace-sass-imports December 13, 2024 10:36 Destroyed
@VincentSmedinga VincentSmedinga merged commit adcd819 into develop Dec 13, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-1001-replace-sass-imports branch December 13, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants