-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace deprecated import statements in Sass with new API #1777
Merged
VincentSmedinga
merged 7 commits into
develop
from
feature/DES-1001-replace-sass-imports
Dec 13, 2024
Merged
feat: Replace deprecated import statements in Sass with new API #1777
VincentSmedinga
merged 7 commits into
develop
from
feature/DES-1001-replace-sass-imports
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 9, 2024 14:50
Destroyed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring. I didn’t anticipate the namespace it would add; let’s decide on a good approach to keep the mixin names user-friendly.
VincentSmedinga
changed the title
feat: Replace SASS imports
feat: Replace deprecated import statements in Sass with new API
Dec 10, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 10, 2024 14:59
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 13, 2024 10:27
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 13, 2024 10:31
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 13, 2024 10:33
Destroyed
VincentSmedinga
approved these changes
Dec 13, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1001-replace-sass-imports
December 13, 2024 10:36
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Applied the SASS recommended migrator to fix the @import deprecation.
Why
Warnings in build output.
How
npm install -g sass-migrator
sass-migrator module --migrate-deps index.scss
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes