feat!: Make active Tab look less like a primary Button #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would be useful for communities that reuse our components and need background and border colours, but we should first consider whether we want to adopt this approach.
alimpens
reviewed
Dec 6, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1018-update-tabs-design
github-actions
bot
temporarily deployed
to
demo-DES-1018-update-tabs-design
alimpens
reviewed
Dec 11, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1018-update-tabs-design
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-1018-update-tabs-design
alimpens
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What
Implements the updated design of Tabs.
Why
The active Tab Button looked too much like a primary Button, making the latter less prominent.
How
Tokens and CSS. I considered leaving some tokens in that we don’t need ourselves but could be useful for other communities to set background and border colors. However, I decided against it (see second commit) as we should first determine whether we want to adopt that approach at all. Even while it would make this change non-breaking.