Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove unused brand colour tokens #1766

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Removes all brand colour tokens we don’t currently use.

Why

Because they get published. We don’t want people to use them. We do want to limit the sizes of our published files.

How

Removed them from the JSON object, backed them up in a text file in the repository.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • None

@VincentSmedinga
Copy link
Contributor Author

The checks will succeed after merging #1765 and merging develop into this branch.

@github-actions github-actions bot temporarily deployed to demo-DES-1031-remove-unused-brand-colour-tokens November 27, 2024 12:11 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1031-remove-unused-brand-colour-tokens November 27, 2024 12:50 Destroyed
@alimpens alimpens merged commit 9071d88 into develop Nov 28, 2024
6 checks passed
@alimpens alimpens deleted the feat/DES-1031-remove-unused-brand-colour-tokens branch November 28, 2024 09:58
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants