Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct layout of Description List if multiple terms share a description #1763

Merged
merged 23 commits into from
Dec 13, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Nov 26, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

An example inline style to prevent a row skip when using multiple terms.

Why

Looks weird

How

An inline style is the most straightforward solution, I've experimenten with sibling selectors and grid-area but it requires too much CSS and you'll never fix it for large lists. This solution also allows the next "normal" item to not need an inline style.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@dlnr dlnr marked this pull request as draft November 26, 2024 10:44
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms November 26, 2024 13:05 Destroyed
@dlnr dlnr marked this pull request as ready for review November 26, 2024 13:06
@dlnr dlnr marked this pull request as draft November 26, 2024 14:01
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms November 26, 2024 14:31 Destroyed
@dlnr dlnr marked this pull request as ready for review November 26, 2024 14:32
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms November 26, 2024 14:44 Destroyed
@dlnr dlnr requested a review from VincentSmedinga December 2, 2024 08:36
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 4, 2024 10:43 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 4, 2024 11:19 Destroyed
Copy link
Contributor Author

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied some suggestions

Co-authored-by: Vincent Smedinga <[email protected]>
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 4, 2024 17:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 08:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 08:42 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 08:48 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 08:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 08:54 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 10:56 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 5, 2024 11:03 Destroyed
@VincentSmedinga VincentSmedinga changed the title fix: Multiple terms in description list fix: Correct layout of Description List if multiple terms share a description Dec 10, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 10, 2024 15:01 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 11, 2024 10:48 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 11, 2024 11:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 11, 2024 17:54 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 13, 2024 10:13 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-998-multiple-terms December 13, 2024 10:39 Destroyed
@VincentSmedinga VincentSmedinga merged commit ca913af into develop Dec 13, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-998-multiple-terms branch December 13, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants