-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct layout of Description List if multiple terms share a description #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
November 26, 2024 13:05
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
November 26, 2024 14:31
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
November 26, 2024 14:44
Destroyed
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 4, 2024 10:43
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 4, 2024 11:19
Destroyed
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.docs.mdx
Outdated
Show resolved
Hide resolved
dlnr
commented
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied some suggestions
Co-authored-by: Vincent Smedinga <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 4, 2024 17:35
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 08:32
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 08:42
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 08:48
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 08:50
Destroyed
…lity and inline style usage
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 08:54
Destroyed
…ted styles and documentation
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 10:56
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 5, 2024 11:03
Destroyed
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
VincentSmedinga
changed the title
fix: Multiple terms in description list
fix: Correct layout of Description List if multiple terms share a description
Dec 10, 2024
packages/react/src/DescriptionList/DescriptionListSection.test.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 10, 2024 15:01
Destroyed
…out and remove unnecessary inline styles
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 11, 2024 10:48
Destroyed
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 11, 2024 11:26
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 11, 2024 17:54
Destroyed
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 13, 2024 10:13
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-998-multiple-terms
December 13, 2024 10:39
Destroyed
VincentSmedinga
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
An example inline style to prevent a row skip when using multiple terms.
Why
Looks weird
How
An inline style is the most straightforward solution, I've experimenten with sibling selectors and grid-area but it requires too much CSS and you'll never fix it for large lists. This solution also allows the next "normal" item to not need an inline style.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes