Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce brand color palettes and rename color tokens #1755

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Nov 15, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

  • This introduces tints and shades of all our colours.
  • All colour tokens have been renamed, e.g. from ams.color.primary-blue to ams.brand.color.blue.60.
  • Interactive components that are invalid now become dark red on hover.
  • The colour ‘green’ has been renamed to ‘lime’, ‘dark green’ to ‘green’, ‘blue’ to ‘azure’, and ‘primary-blue’ to ‘blue’, and the other ‘primary’ colours have lost that prefix as well.
  • As little as possible usages of colour have been changed – only everything ‘disabled’ now uses neutral.60 consistently.

Why

  • To define a darker hover color and a lighter background colour for every colour in the palette.
  • To introduce a consistent naming scheme for all colours.

How

  • Generated tints and shades through Supa Palette for Figma
  • Replaced ams.color.* with ams.brand.color.*
  • Updated all token references in components
  • Updated the Color Palette component and colour docs

Upcoming pull requests will update the colour names in props, introduce common tokens, add more consistency, prefix other brand tokens, etc.

@github-actions github-actions bot temporarily deployed to demo-DES-1031-brand-color-palette November 18, 2024 10:59 Destroyed
@dlnr
Copy link
Contributor

dlnr commented Nov 18, 2024

I would like to suggest that we merge this not in develop but in branch where we can merge multiple colour palette changes. Because this changes a lot of common (component) tokens that will probably be changed again when we implement semantic colour tokens.

@VincentSmedinga VincentSmedinga merged commit cf37ecc into develop Nov 19, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-1031-brand-color-palette branch November 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants