Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add File List component to display below a File Input #1751

Merged
merged 26 commits into from
Dec 13, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Nov 13, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This is an optional file list to add to a file input or uploader component.

Why

Our designers often use a file preview when uploading documents.

How

A separate component, to which you can use click handlers or context or whatever method you need to display files.
It also introduced utils to format file type and file size.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 13, 2024 19:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 25, 2024 07:28 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 25, 2024 07:42 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a nice addition!

packages/react/src/FileList/FileList.test.tsx Show resolved Hide resolved
packages/css/src/components/file-list/README.md Outdated Show resolved Hide resolved
packages/react/src/FileList/FileList.tsx Outdated Show resolved Hide resolved
packages/css/src/components/file-list/file-list.scss Outdated Show resolved Hide resolved
packages/react/src/FileList/FileList.tsx Outdated Show resolved Hide resolved
packages/react/src/common/formatFileType.tsx Outdated Show resolved Hide resolved
packages/react/src/common/formatFileType.tsx Outdated Show resolved Hide resolved
packages/react/src/common/index.ts Outdated Show resolved Hide resolved
storybook/src/components/FileList/FileList.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 27, 2024 15:48 Destroyed
Copy link
Contributor Author

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part 1 of 2, will round it up later.

packages/react/src/FileList/FileList.tsx Outdated Show resolved Hide resolved
packages/react/src/FileList/FileList.tsx Outdated Show resolved Hide resolved
storybook/src/components/FileList/FileList.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 29, 2024 07:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 29, 2024 08:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 29, 2024 10:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 29, 2024 14:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component November 29, 2024 14:25 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 2, 2024 14:33 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 2, 2024 14:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 10:43 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 11:20 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:46 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:47 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:48 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:54 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-969-file-list-component December 13, 2024 12:56 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: FileList with input example feat: Add File List component to display below a File Input Dec 13, 2024
@VincentSmedinga VincentSmedinga merged commit 0192404 into develop Dec 13, 2024
7 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-969-file-list-component branch December 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants