-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rename reset mixins to include element name #1738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
Nov 4, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1013-rename-mixins-to-elements
November 8, 2024 11:24
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-1013-rename-mixins-to-elements
November 8, 2024 13:03
Destroyed
VincentSmedinga
approved these changes
Nov 8, 2024
github-actions
bot
temporarily deployed
to
demo-DES-1013-rename-mixins-to-elements
November 8, 2024 13:06
Destroyed
alimpens
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What
Rename Sass reset mixins to include the HTML or common name of the element they reset.
Why
This refactor is not really necessary, but makes it somewhat easier to understand what each reset mixin does. It also helps with global searches on the word "reset".
How
Global search on
@mixin reset
and then changing those names by inluding the element name after a dash.Checklist
Additional notes
paragraph
instead ofp
,list
instead ofol
orul
andheading
instead ofh1
toh6
. Please check if this makes sense.dd
and alabel
element. In this case the reset is namedreset-label-or-description
.