Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename reset mixins to include element name #1738

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

RubenSibon
Copy link
Contributor

@RubenSibon RubenSibon commented Nov 1, 2024

Describe the pull request

What

Rename Sass reset mixins to include the HTML or common name of the element they reset.

Why

This refactor is not really necessary, but makes it somewhat easier to understand what each reset mixin does. It also helps with global searches on the word "reset".

How

Global search on @mixin reset and then changing those names by inluding the element name after a dash.

Checklist

Additional notes

  • There are some instances where an HTML name was not used: paragraph instead of p, list instead of ol or ul and heading instead of h1 to h6. Please check if this makes sense.
  • One reset applies to both a dd and a label element. In this case the reset is named reset-label-or-description.

@RubenSibon RubenSibon self-assigned this Nov 1, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-1013-rename-mixins-to-elements November 8, 2024 11:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1013-rename-mixins-to-elements November 8, 2024 13:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1013-rename-mixins-to-elements November 8, 2024 13:06 Destroyed
@alimpens alimpens merged commit 92312fa into develop Nov 8, 2024
6 checks passed
@alimpens alimpens deleted the feat/DES-1013-rename-mixins-to-elements branch November 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants