Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve warnings against missing array keys in Button #1736

Merged
merged 9 commits into from
Nov 4, 2024
Merged

fix: Resolve warnings against missing array keys in Button #1736

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9659b95
Always give icon a key
dlnr Nov 1, 2024
ae2da82
Update packages/react/src/Button/Button.tsx
VincentSmedinga Nov 4, 2024
1a0106d
Choose fragments over arrays and keys
VincentSmedinga Nov 4, 2024
193b257
Remove another key
VincentSmedinga Nov 4, 2024
bd7fd38
Remove explicit ‘true’
VincentSmedinga Nov 4, 2024
f79b546
Conclude that inline conditions are simplest anyway
VincentSmedinga Nov 4, 2024
711b1be
Fix condition
VincentSmedinga Nov 4, 2024
c943835
Merge branch 'develop' into fix/1732-error-on-icon-prop
VincentSmedinga Nov 4, 2024
1ffb676
Fix another condition
VincentSmedinga Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const Button = forwardRef(
case !icon:
return children
case iconBefore:
return [<Icon svg={icon} size="level-5" />, children]
return [<Icon key={1} svg={icon} size="level-5" />, children]
case iconOnly:
return [
<Icon key={1} svg={icon} size="level-5" square={true} />,
Expand All @@ -57,7 +57,7 @@ export const Button = forwardRef(
</span>,
]
default:
return [children, <Icon svg={icon} size="level-5" />]
return [children, <Icon key={2} svg={icon} size="level-5" />]
VincentSmedinga marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down