Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove lodash #1667

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: Remove lodash #1667

merged 1 commit into from
Oct 16, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 16, 2024

Describe the pull request

Lodash was not needed to debounce a resize event in ImageSlider.

What

  • Uninstalled lodash
  • Removed debounce from ImageSlider

Why

The 200ms delay isn't needed. Tested on iOs where the bug occurred.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-remove-lodash October 16, 2024 07:52 Destroyed
@alimpens alimpens merged commit 9db04cf into develop Oct 16, 2024
6 checks passed
@alimpens alimpens deleted the fix/remove-lodash branch October 16, 2024 07:58
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@VincentSmedinga VincentSmedinga Awaiting requested review from VincentSmedinga

@RubenSibon RubenSibon Awaiting requested review from RubenSibon

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlnr @alimpens