fix: JavaScript guard for maximum span of Grid Cells on smaller viewports #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/DES-962-grid-max-span-for-smaller-viewports
…/DES-962-grid-max-span-for-smaller-viewports-js-guard
|
It is possible to solve the problem with JavaScript, but adds processing time in runtime and a lot of conditional code. That's not a preferable solution. |
RubenSibon
deleted the
fix/DES-962-grid-max-span-for-smaller-viewports-js-guard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
(What changes does this PR introduce?)
Why
(Why are these changes necessary?)
How
(How were these changes implemented? Provide a brief overview of the approach taken and any key considerations.)
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes