Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let Grid and Grid Cell render any structural tag #1662

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This provides more options for Grid and Grid Cell to render a semantic HTML element instead of a div.

Why

People should be able to apply the features of these components to any HTML element. Otherwise, they must add an unnecessary wrapper element.

How

Extracted from #1607. Added options to the as prop, extracted a configuration object for it, included all of them in the unit tests.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

packages/react/src/Grid/Grid.test.tsx Show resolved Hide resolved
packages/react/src/Grid/Grid.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Grid/Grid.tsx Outdated Show resolved Hide resolved
packages/react/src/common/accessibility.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-884-semantic-elements-for-grid November 8, 2024 15:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-semantic-elements-for-grid November 8, 2024 15:38 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-semantic-elements-for-grid November 8, 2024 17:46 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-semantic-elements-for-grid November 11, 2024 08:56 Destroyed
@VincentSmedinga VincentSmedinga merged commit 9bbb43a into develop Nov 11, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-884-semantic-elements-for-grid branch November 11, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants