Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Iconset update #1656

Closed
wants to merge 4 commits into from
Closed

feat!: Iconset update #1656

wants to merge 4 commits into from

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 14, 2024

Describe the pull request

Updated iconset and workflow. This might break your application because there are some icons missing, missing icons in our stories have been copied.

What

Replaced iconset with new icons.

Why

New iconset.

How

  • Figma branch where iconset is exportable
  • SVGO script that only removes svg markup that does not break the icons (like fill-rule)
  • Updated Icons docs
  • Replaced renamed icons in stories
  • Copied missing icons to figma for designers to consider.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t seem ready for a review. Many icons aren’t square and don’t come in filled and solid couples.

@dlnr
Copy link
Contributor Author

dlnr commented Oct 15, 2024

Many icons aren’t square and don’t come in filled and solid couples.

  • The square part comes as a prop in the Icon component, I did not see the need to square every viewbox. Which is also impossible in Figma, the svg export resizes the viewbox to the bounds of the shape(s).
    • Manually changing the viewbox (to 0 0 24 24 for example) would break the centering of the shape using the square prop in icon, it would be aligned top left.
  • The iconset duplicated a lot of icons that did not have an outline counterpart (like the chevron or menu) in order to not break the fill property in Figma. Moving away from the fill prop and having separate components (or shapes) for all icons (like House and HouseOutline) removed the need to have duplicate icons. ie. It would be redundant to have ChevronDown and ChevronDownOutline if they are identical.
    Consider the usage: <Icon svg={<ChevronDownOutline />} square />

@dlnr dlnr closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants