-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Button to display an icon without a label #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-859-icon-only-button
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 11, 2024 12:38
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 14, 2024 10:23
Destroyed
…into feature/DES-859-icon-only-button
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 14, 2024 10:26
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 14, 2024 10:28
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 14, 2024 11:08
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 14, 2024 11:16
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 15, 2024 07:50
Destroyed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve added descriptions to the examples.
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 18, 2024 14:40
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 18, 2024 14:43
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 07:53
Destroyed
alimpens
reviewed
Oct 21, 2024
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 08:45
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 09:16
Destroyed
dlnr
commented
Oct 21, 2024
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 09:39
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 11:27
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 12:36
Destroyed
VincentSmedinga
previously approved these changes
Oct 21, 2024
alimpens
reviewed
Oct 21, 2024
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 21, 2024 18:30
Destroyed
…into feature/DES-859-icon-only-button
github-actions
bot
temporarily deployed
to
demo-DES-859-icon-only-button
October 22, 2024 11:52
Destroyed
VincentSmedinga
approved these changes
Oct 22, 2024
alimpens
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
While the story wants the tertiary button to be able to replace the IconButton component I've tied the Figma button API to the code. Because narrowing the "icon only" variant to just the tertiary button would require it be a separate component or have dodgy conditionals. Also the map wil need a secondary icon only variant or a button group of icon buttons might need a call to action.
What
I've reverted the changes to the IconPosition enum (not using iconStart and iconEnd) because using code connect this will match the React code snippet ,it saves a couple of properties and prevents the ability to have two icons in a button. It does introduce more variants in Figma, but this should be fine.
The label property was also not needed and the "icon only" variant introduces a span around the children with a visually hidden class.
Why
Previously an icon would have to be manually added to the children of the button, the size of button would be up to the developer, as well as adding a square attribute. There were plenty of ways to introduce errors in the rendering of the button. This fixes that while also having an API to change the position of the icon.
How
This PR introduces two props (icon and iconPosition) and conditionals to render the children.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes