Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make Text Input and Text Area uncontrolled in stories #1533

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It changes Text Input and Text Area to uncontrolled components in Storybook.

Why

Controlled components do not change automatically when interacting with them, you have to set an onChange handler for that. We didn't for Text Input and Text Area, which means you can't change the text. This PR fixes that.

How

By using defaultValue instead of value.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-make-text-area-and-input-uncontrolled August 26, 2024 08:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-make-text-area-and-input-uncontrolled August 26, 2024 09:33 Destroyed
@alimpens alimpens merged commit d4da3f7 into develop Aug 26, 2024
6 checks passed
@alimpens alimpens deleted the make-text-area-and-input-uncontrolled branch August 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants