Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove margin Safari sets on buttons #1529

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It removes the margin older Safari sets on buttons

Why

To have consistent styling between older Safari and other browsers

How

By setting margin-block and margin-inline to 0

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-remove-safari-button-margin August 24, 2024 07:48 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s assess for how many people we add these lines of code.

@github-actions github-actions bot temporarily deployed to demo-remove-safari-button-margin August 26, 2024 08:41 Destroyed
@VincentSmedinga VincentSmedinga merged commit 2ccc1bc into develop Aug 26, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the bug/remove-safari-button-margin branch August 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants