feat!: Remove HeadingLevel type, group Heading sizes in story #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentSmedinga
commented
Jul 15, 2024
•
VincentSmedinga
commented
- Having all semantic headings in one example makes it easier to visually compare them
- We didn’t have an example of sizes yet; now we do
- I could use this to assess the new text sizes for compact mode
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
dlnr
previously approved these changes
Jul 16, 2024
alimpens
reviewed
Jul 16, 2024
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
alimpens
reviewed
Jul 19, 2024
alimpens
changed the title
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
# Conflicts: # packages/react/src/FormErrorList/FormErrorList.tsx
github-actions
bot
temporarily deployed
to
demo-DES-882-1-iterate-heading-props
VincentSmedinga
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.