feat!: Add and rename Pagination props, remove use of aria-label
#1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
reviewed
Jul 12, 2024
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
alimpens
reviewed
Jul 19, 2024
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
alimpens
reviewed
Jul 23, 2024
…ub.com:Amsterdam/design-system into feat/DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
Important: breaking change for the Pagination API This renames Pagination properties to no longer refer to aria-label, but to visually hidden labels.
…t/DES-849-aria-label-to-ams-visually-hidden
…ub.com:Amsterdam/design-system into feat/DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
RubenSibon
changed the title
alimpens
reviewed
Jul 24, 2024
alimpens
reviewed
Jul 24, 2024
alimpens
changed the title
aria-label
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
…t/DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
alimpens
approved these changes
Jul 26, 2024
github-actions
bot
temporarily deployed
to
demo-DES-849-aria-label-to-ams-visually-hidden
dlnr
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The Amsterdam Design System advices against using
aria-label. We should then not use the bad practice in our own components.What
This branch removes usage of
aria-labeland replaces it with the labels inspans with theams-visually-hiddenclass name.Additional notes
nextAriaLabelandpreviousAriaLabeland thus break the API? Yes, the props have been changed, thus breaking the API.