feat: Add focus on initial render to Form Error List #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
…tps://github.com/Amsterdam/design-system into feature/DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
VincentSmedinga
previously approved these changes
Jul 17, 2024
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
…ari for Mac" This reverts commit 51bd3b6.
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
VincentSmedinga
approved these changes
Jul 19, 2024
github-actions
bot
temporarily deployed
to
demo-DES-793-add-autofocus-to-form-error-list
VincentSmedinga
deleted the
feature/DES-793-add-autofocus-to-form-error-list
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds focus on initial render to Form Error List, as prescribed by gov.uk.
I had to split the component in 2 parts. One part sets the document title, creates a state and returns early if there are no errors.
The second part is what renders when the component does receive a list of errors.
These parts had to be separated because the early return caused the hooks used (useRef, useImparitiveHandle, useEffect) to be called conditionally, which isn't allowed by the rules of hooks.
The
hasFocusedOncestate is necessary to prevent the component receiving focus every time it's shown on screen. React Hook Form validates on submit and revalidates on change, which causes the component to appear while your typing. You don't want to move focus from the input you're typing in to the Form Error List in those cases.