chore: Use Fields in FieldSet docs #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
changed the title
|
I agree that option 2 is the right choice. The sub-fields or inputs already get the detailed error message that provides the user with clear and actionable feedback on what to do, but if the fields belong together in a set then it makes sense that the error indication also belongs to the entire field set. |
RubenSibon
approved these changes
Jun 28, 2024
VincentSmedinga
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do we want to do with the error bar for FieldSets containing Fields? Should the error bar only be shown for the Field that has an input with an error (so
<Field invalid="true")? Or should it be shown for the entire FieldSet (so<FieldSet invalid="true")?Currently, the second option is shown.