Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow various types of text input #1259

Merged
merged 10 commits into from
Jun 21, 2024
Prev Previous commit
Apply suggestions from code review
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
VincentSmedinga and alimpens authored Jun 21, 2024
commit ff19cca16ebbb0a1c81133c08d96b26fbe547d88
2 changes: 1 addition & 1 deletion packages/react/src/DateInput/DateInput.test.tsx
Original file line number Diff line number Diff line change
@@ -68,7 +68,7 @@ describe('Date input', () => {

describe('Type', () => {
dateInputTypes.map((type) =>
it(`passes on the ‘${type}’ type`, () => {
it(`sets the ‘${type}’ type`, () => {
const { container } = render(<DateInput type={type} />)

const component = container.querySelector(':only-child')
4 changes: 2 additions & 2 deletions packages/react/src/TextInput/TextInput.test.tsx
Original file line number Diff line number Diff line change
@@ -122,7 +122,7 @@ describe('Text input', () => {
textInputTypes
.filter((type) => type !== 'password')
.map((type) =>
it(`passes on the ‘${type}’ type`, () => {
it(`sets the ‘${type}’ type`, () => {
render(<TextInput type={type} />)

const component = screen.getByRole('textbox')
@@ -132,7 +132,7 @@ describe('Text input', () => {
)

// https://github.com/testing-library/dom-testing-library/issues/567
it(`passes on the ‘password’ type`, () => {
it('sets the ‘password’ type', () => {
render(
<>
<Label htmlFor="password-field">Password</Label>