Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow a specific Tab to be made active #1258

Merged
merged 23 commits into from
Jun 17, 2024
Merged

feat: Allow a specific Tab to be made active #1258

merged 23 commits into from
Jun 17, 2024

Conversation

RubenSibon
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 12, 2024 12:55 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 13, 2024 07:34 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Initial active tab feat: Allow a specific Tab to be active initially Jun 13, 2024
@VincentSmedinga VincentSmedinga changed the title feat: Allow a specific Tab to be active initially feat: Allow a specific Tab to be initially active Jun 13, 2024
@VincentSmedinga VincentSmedinga changed the title feat: Allow a specific Tab to be initially active feat: Allow a specific Tab to be made active Jun 13, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 08:39 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 12:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 12:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 14:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 14:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 14:47 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 14, 2024 14:53 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 15, 2024 08:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 15, 2024 08:34 Destroyed
VincentSmedinga
VincentSmedinga approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

storybook/src/components/Tabs/Tabs.stories.tsx Show resolved Hide resolved
packages/react/src/Tabs/Tabs.test.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-676-initial-active-tab June 17, 2024 07:56 Destroyed
@VincentSmedinga VincentSmedinga merged commit 9d2f01d into develop Jun 17, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-676-initial-active-tab branch June 17, 2024 12:53
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@alimpens alimpens Awaiting requested review from alimpens

@dlnr dlnr Awaiting requested review from dlnr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenSibon @VincentSmedinga @dlnr