Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change values for tall, wide, and extra wide aspect ratios #1254

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

VincentSmedinga
Copy link
Contributor

  • The 2x-wide proportion has changed from 32:9 to 16:5
  • The wide proportion has changed from 5:4 to 4:3
  • The tall proportion has changed from 4:5 to 3:4

@github-actions github-actions bot temporarily deployed to demo-update-aspect-ratio-tokens June 7, 2024 09:54 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Change values for 32:9 and 5:4 aspect ratios feat: Change values for tall, wide, and extra wide aspect ratios Jun 7, 2024
@github-actions github-actions bot temporarily deployed to demo-update-aspect-ratio-tokens June 12, 2024 09:38 Destroyed
Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I checked the Card and Overlap components out in the deployment.

@VincentSmedinga VincentSmedinga merged commit 478508a into develop Jun 12, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/update-aspect-ratio-tokens branch June 12, 2024 10:50
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants