feat: Add Table of Contents component #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-654-table-of-content
…into feature/DES-654-table-of-content
VincentSmedinga
changed the title
alimpens
reviewed
Jun 5, 2024
storybook/src/components/TableOfContents/TableOfContents.stories.tsx
Outdated
Show resolved
Hide resolved
packages/css/src/components/table-of-contents/table-of-contents.scss
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/ams/table-of-contents.tokens.json
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/ams/table-of-contents.tokens.json
Outdated
Show resolved
Hide resolved
proprietary/tokens/src/components/ams/table-of-contents.tokens.json
Outdated
Show resolved
Hide resolved
packages/css/src/components/table-of-contents/table-of-contents.scss
Outdated
Show resolved
Hide resolved
storybook/src/components/TableOfContents/TableOfContents.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/TableOfContents/TableOfContents.stories.tsx
Outdated
Show resolved
Hide resolved
…into feature/DES-654-table-of-content
github-actions
bot
temporarily deployed
to
demo-DES-654-table-of-content
github-actions
bot
temporarily deployed
to
demo-DES-654-table-of-content
VincentSmedinga
previously approved these changes
Jun 6, 2024
github-actions
bot
temporarily deployed
to
demo-DES-654-table-of-content
github-actions
bot
temporarily deployed
to
demo-DES-654-table-of-content
VincentSmedinga
approved these changes
Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styled after the design for amsterdam.nl, Bas hinted that the chevrons were floating so I removed them.
This component has no added scripts to set an active state while scrolling or folding children (so chevron also not needed).
We need to await futher refinement for this component, this is just the basics.