chore: Correct token nesting for inverse color #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
May 31, 2024
| @@ -6,7 +6,11 @@ | |||
| "font-size": { "value": "{ams.text.level.3.font-size}" }, | |||
| "font-weight": { "value": "{ams.text.font-weight.bold}" }, | |||
| "line-height": { "value": "{ams.text.level.3.line-height}" }, | |||
| "inverse-color": { "value": "{ams.color.primary-white}" } | |||
| "inverse": { | |||
| "color": { | |||
There was a problem hiding this comment.
This means the modifier name is now 'inverse', right, not 'inverse-color'?
So it should be ams-paragraph--inverse, for example?
Or should the token be ams.paragraph.inverse-color.color?
There was a problem hiding this comment.
Good point. I’ve mentioned this change in a broader ticket on this API. We can leave this as is until then.
| @@ -6,7 +6,11 @@ | |||
| "font-size": { "value": "{ams.text.level.3.font-size}" }, | |||
| "font-weight": { "value": "{ams.text.font-weight.bold}" }, | |||
| "line-height": { "value": "{ams.text.level.3.line-height}" }, | |||
| "inverse-color": { "value": "{ams.color.primary-white}" } | |||
| "inverse": { | |||
| "color": { | |||
There was a problem hiding this comment.
Changing the token structure is technically a breaking change, I think
|
Closing – doing this right requires changing CSS classes and React props as well, and we’re planning to revisit the entire API around colours soon anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn’t affect the actual token names, but having
inverse-coloras a level violates the rule that the name of the leaf must be a CSS property.