Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extra types for text and date inputs #1233

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react/src/DateInput/DateInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,14 @@ import clsx from 'clsx'
import { forwardRef } from 'react'
import type { ForwardedRef, InputHTMLAttributes } from 'react'

export type DateInputProps = InputHTMLAttributes<HTMLInputElement>
export type DateInputProps = {
/** The available types are 'date', 'datetime-local', 'month', 'week' */
type?: 'date' | 'datetime-local' | 'month' | 'week'
} & InputHTMLAttributes<HTMLInputElement>

export const DateInput = forwardRef(
({ className, ...restProps }: DateInputProps, ref: ForwardedRef<HTMLInputElement>) => (
<input {...restProps} ref={ref} className={clsx('ams-date-input', className)} type="date" />
({ className, type = 'date', ...restProps }: DateInputProps, ref: ForwardedRef<HTMLInputElement>) => (
<input {...restProps} ref={ref} className={clsx('ams-date-input', className)} type={type} />
),
)

Expand Down
9 changes: 6 additions & 3 deletions packages/react/src/TextInput/TextInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,14 @@ import clsx from 'clsx'
import { forwardRef } from 'react'
import type { ForwardedRef, InputHTMLAttributes } from 'react'

export type TextInputProps = InputHTMLAttributes<HTMLInputElement>
export type TextInputProps = {
/** The options for type in this input are 'text', 'password', 'email, 'tel', 'url' */
type?: 'text' | 'password' | 'email' | 'tel' | 'url'
} & InputHTMLAttributes<HTMLInputElement>

export const TextInput = forwardRef(
({ className, ...restProps }: TextInputProps, ref: ForwardedRef<HTMLInputElement>) => (
<input {...restProps} className={clsx('ams-text-input', className)} ref={ref} type="text" />
({ className, type = 'text', ...restProps }: TextInputProps, ref: ForwardedRef<HTMLInputElement>) => (
<input {...restProps} className={clsx('ams-text-input', className)} ref={ref} type={type} />
),
)

Expand Down
14 changes: 14 additions & 0 deletions storybook/src/components/DateInput/DateInput.docs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,17 @@ import README from "../../../../packages/css/src/components/date-input/README.md
## Disabled

<Canvas of={DateInputStories.Disabled} />

## Other Types

### Local date and time

<Canvas of={DateInputStories.DateTimeLocal} />

## Month

<Canvas of={DateInputStories.Month} />

## Week

<Canvas of={DateInputStories.Week} />
18 changes: 18 additions & 0 deletions storybook/src/components/DateInput/DateInput.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,21 @@ export const Disabled: Story = {
disabled: true,
},
}

export const DateTimeLocal: Story = {
args: {
type: 'datetime-local',
},
}

export const Month: Story = {
args: {
type: 'month',
},
}

export const Week: Story = {
args: {
type: 'week',
},
}
18 changes: 18 additions & 0 deletions storybook/src/components/TextInput/TextInput.docs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,21 @@ Incorrectly filled input fields become visible immediately.
### Disabled

<Canvas of={TextInputStories.Disabled} />

## Other Types

### Password

<Canvas of={TextInputStories.Password} />

### Email

<Canvas of={TextInputStories.Email} />

## Tel

<Canvas of={TextInputStories.Tel} />

### URL

<Canvas of={TextInputStories.Url} />
27 changes: 26 additions & 1 deletion storybook/src/components/TextInput/TextInput.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const meta = {
Toggling the invalid control sets the required attribute on the input
and requires it to match "ž". Wrapped in a form, this triggers the invalid state.
*/}
<TextInput pattern={invalid ? '[ž]' : '.*'} required={invalid} onChange={handleChange} {...args} />
<TextInput required={invalid} onChange={handleChange} {...args} />
</form>
)
},
Expand All @@ -51,6 +51,7 @@ export const Placeholder: Story = {
export const Invalid: Story = {
args: {
invalid: true,
pattern: '[ž]',
},
}

Expand All @@ -59,3 +60,27 @@ export const Disabled: Story = {
disabled: true,
},
}

export const Password: Story = {
args: {
type: 'password',
},
}

export const Email: Story = {
args: {
type: 'email',
},
}

export const Tel: Story = {
args: {
type: 'tel',
},
}

export const Url: Story = {
args: {
type: 'url',
},
}
Loading