feat!: Rename Breadcrumb Item to Link #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlnr
previously approved these changes
May 17, 2024
RubenSibon
previously approved these changes
May 17, 2024
alimpens
reviewed
May 17, 2024
github-actions
bot
temporarily deployed
to
demo-DES-772-rename-breadcrumb-item-to-link
github-actions
bot
temporarily deployed
to
demo-DES-772-rename-breadcrumb-item-to-link
VincentSmedinga
deleted the
feature/DES-772-rename-breadcrumb-item-to-link
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breadcrumb is a list of links. The ‘item’ level in between is implicit; the link is what matters. This change reflects that. Now the
hrefprop is on a link, not an item.Changes:
Breadcrumb.Itemcomponent has been renamed toBreadcrumb.Linkaelement instead of theli-itemfragment of the design tokens has been removed