fix!: Flatten token names for default text size and line height #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `medium` font-size and line-height are the default for Paragraph and Link List Link. The absence of a corresponding option for the `size` prop reflects this, and so should the names of their design tokens.
VincentSmedinga
changed the title
alimpens
approved these changes
May 8, 2024
github-actions
bot
temporarily deployed
to
demo-flatten-medium-text-size-tokens
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mediumfont size and line height are the default for Paragraph and Link List Link. The absence of a corresponding option for thesizeprop reflects this, as should the names of their design tokens.This is how we do it in Ordered List and Unordered List as well.