chore: Clarify spacious and compact values for Grid Space #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
RubenSibon
approved these changes
Apr 25, 2024
alimpens
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received feedback that the difference in the columns for the tables listing the values for Grid Space on various screen widths were confusing, and I agreed.
In a couple of iterations, I decided to use a step of 256 pixels for every column; some were 512 before. Compact Mode starts at 1088 and you can’t get down to 320 with steps of 512. And both tables’ columns needed to align.
The first cells in the table for compact mode have been merged to highlight that their values are the same. This required using an HTML table instead of Markdown.
I experimented with hiding the obscure columns of 2368 and 2624, but this is how the tokens work; I decided to remain complete.
Links to the pages: current, updated.