Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @testing-library/dom from 9.3.4 to 10.0.0 #1171

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 10, 2024

Bumps @testing-library/dom from 9.3.4 to 10.0.0.

Release notes

Sourced from @​testing-library/dom's releases.

v10.0.0

10.0.0 (2024-04-08)

Bug Fixes

  • use defineProperty on the error object instead of setting the message directly (#1268) (3580f25), closes #1259

Features

  • Drop support for Node.js 14.x and Node.js 16.x and add support for Node 20.x (#1255) (452097b)
  • upgrade aria-query to 5.3.0 (#1241) (2c57055), closes #1240

BREAKING CHANGES

  • Minimum supported Node.js version is 18.0
  • New version of aria-query changes various roles. Check out the changed tests in 2c57055 to get an overview about what changed.

v10.0.0-alpha.3

10.0.0-alpha.3 (2024-04-04)

Bug Fixes

  • Stop calling waitFor callback after timeout (#1271) (9aaf715)
  • use defineProperty on the error object instead of setting the message directly (#1261) (270a531), closes #1259

v10.0.0-alpha.2

10.0.0-alpha.2 (2023-10-03)

Bug Fixes

  • use defineProperty on the error object instead of setting the message directly (#1268) (3580f25), closes #1259

Features

v10.0.0-alpha.1

10.0.0-alpha.1 (2023-09-10)

... (truncated)

Commits
  • eef23ca test: Fix Codecov in CI (#1297)
  • 6ad31ec release: 10.0.0
  • cb57f99 Merge branch 'main' into alpha
  • 37ccada Merge branch 'main' into alpha
  • 3580f25 fix: use defineProperty on the error object instead of setting the message di...
  • 2c57055 feat: upgrade aria-query to 5.3.0 (#1241)
  • 452097b feat: Drop support for Node.js 14.x and Node.js 16.x and add support for Node...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 10, 2024
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 9.3.4 to 10.0.0.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/dom-testing-library@v9.3.4...v10.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/dom"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library/dom-10.0.0 branch from 28da204 to b69bf36 Compare April 10, 2024 11:06
@github-actions github-actions bot temporarily deployed to demo-npm_and_yarn/testing-library/dom-10.0.0 April 10, 2024 11:37 Destroyed
@VincentSmedinga
Copy link
Contributor

VincentSmedinga commented Apr 10, 2024

Running the tests locally emits errors for a couple of components, like so:

console.error
    Warning: An update to ControlledComponent inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    […]
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://reactjs.org/link/wrap-tests-with-act
        at ControlledComponent (/Volumes/Code/amsterdam/design-system/design-system/packages/react/src/SearchField/SearchFieldInput.test.tsx:46:41)

      46 |       const [value, setValue] = useState('Hello')
      47 |
    > 48 |       return <SearchFieldInput value={value} onChange={(e) => setValue(e.target.value)} />
         |                                                               ^
      49 |     }
      50 |
      51 |     render(<ControlledComponent />)

Doesn’t seem related to this update though. Should we follow something like this anyway?

@github-actions github-actions bot temporarily deployed to demo-npm_and_yarn/testing-library/dom-10.0.0 April 19, 2024 08:09 Destroyed
@alimpens
Copy link
Contributor

Running the tests locally emits errors for a couple of components, like so:

console.error
    Warning: An update to ControlledComponent inside a test was not wrapped in act(...).
    
    When testing, code that causes React state updates should be wrapped into act(...):
    
    […]
    
    This ensures that you're testing the behavior the user would see in the browser. Learn more at https://reactjs.org/link/wrap-tests-with-act
        at ControlledComponent (/Volumes/Code/amsterdam/design-system/design-system/packages/react/src/SearchField/SearchFieldInput.test.tsx:46:41)

      46 |       const [value, setValue] = useState('Hello')
      47 |
    > 48 |       return <SearchFieldInput value={value} onChange={(e) => setValue(e.target.value)} />
         |                                                               ^
      49 |     }
      50 |
      51 |     render(<ControlledComponent />)

Doesn’t seem related to this update though. Should we follow something like this anyway?

Yes, good idea! I've added a ticket for it.

@alimpens alimpens merged commit 2aab03b into develop Apr 19, 2024
4 checks passed
@alimpens alimpens deleted the dependabot/npm_and_yarn/testing-library/dom-10.0.0 branch April 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants